Skip to content

Remove leaking abstraction and hide internals of corrupt obj deleter #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: delete-undecryptable
Choose a base branch
from
Open

Remove leaking abstraction and hide internals of corrupt obj deleter #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
71a136f
api: add a new field to meta/v1 DeleteOptions
tkashem Sep 23, 2024
7b138af
api: run codegen
tkashem Sep 23, 2024
a382f2f
add validation for the new delete option
tkashem Oct 7, 2024
887587f
extend storage error
tkashem Sep 20, 2024
7126932
implement unsafe deletion
tkashem Sep 20, 2024
b4c2e6e
wire up unsafe deletion from the delete resource handler
tkashem Sep 20, 2024
4aed65a
aggregate a list of errors identifying objects that are corrupt
tkashem Sep 20, 2024
e3a79fa
add API status error
tkashem Sep 20, 2024
b545da7
refactor: extend newTransformTest to enable/disable RBAC
tkashem Oct 8, 2024
7677cf6
add an integration test that exercises the unsafe delete flow
tkashem Oct 8, 2024
0b78324
add admission for unsafe delete
tkashem Oct 7, 2024
94e0fd4
add integration test to verify that LIST returns corrupt object keys
tkashem Oct 15, 2024
4e0dbfc
use resource version as a precondition to unsafe delete
tkashem Oct 18, 2024
bb8a187
Remove leaking abstraction and hide internals of corrupt obj deleter
sttts Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
422 changes: 422 additions & 0 deletions api/openapi-spec/swagger.json
View file
Open in desktop

Large diffs are not rendered by default.

265 changes: 265 additions & 0 deletions api/openapi-spec/v3/api__v1_openapi.json
View file
Open in desktop

Large diffs are not rendered by default.

76 changes: 76 additions & 0 deletions api/openapi-spec/v3/apis__admissionregistration.k8s.io__v1_openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,6 +1280,10 @@
"format": "int64",
"type": "integer"
},
"ignoreStoreReadErrorWithClusterBreakingPotential": {
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"type": "boolean"
},
"kind": {
"description": "Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds",
"type": "string"
Expand Down Expand Up @@ -2441,6 +2445,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -2850,6 +2863,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down Expand Up @@ -3252,6 +3274,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -3661,6 +3692,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down Expand Up @@ -4342,6 +4382,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -4751,6 +4800,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down Expand Up @@ -5153,6 +5211,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -5562,6 +5629,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down
40 changes: 40 additions & 0 deletions api/openapi-spec/v3/apis__admissionregistration.k8s.io__v1alpha1_openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,10 @@
"format": "int64",
"type": "integer"
},
"ignoreStoreReadErrorWithClusterBreakingPotential": {
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"type": "boolean"
},
"kind": {
"description": "Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds",
"type": "string"
Expand Down Expand Up @@ -1953,6 +1957,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -2362,6 +2375,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down Expand Up @@ -3043,6 +3065,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "A selector to restrict the list of returned objects by their labels. Defaults to everything.",
"in": "query",
Expand Down Expand Up @@ -3452,6 +3483,15 @@
"uniqueItems": true
}
},
{
"description": "IgnoreStoreReadErrorWithClusterBreakingPotential, if set to true, will trigger an unsafe deletion of the resource in case the normal deletion flow fails with a corrupt object error. A resource is considered corrupt if it can not be retrieved from the underlying storage because of a) its data can not be transformed successfully, or b) it fails to decode into an object. NOTE: unsafe deletion ignores finalzer constraints, skips precondition checks, or any post deletion hooks and removes the object from the storage. WARNING: This will break the cluster if the resource has any dependencies. Use only if you REALLY know what you are doing. WARNING: Vendor(s) will most likely consider enablement of this option to be in violation of the support of their product. The default value is nil, and the user must opt in to enable it",
"in": "query",
"name": "ignoreStoreReadErrorWithClusterBreakingPotential",
"schema": {
"type": "boolean",
"uniqueItems": true
}
},
{
"description": "Deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the \"orphan\" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both.",
"in": "query",
Expand Down
Loading