feat: add proxy support #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
reviewed
Jun 9, 2025
| @@ -648,6 +677,13 @@ def create_parser() -> ArgumentParser: | |||
| action="store_true", | |||
| help='Display longform options over shortform') | |||
|
|
|||
| parser.add_argument('-x', '--proxy', | |||
There was a problem hiding this comment.
I assume the -x shorthand is taken from cURL (or similar)? 👀 Do we want to leave that reserved in case something is added in future with that shorthand in the client spec?
There was a problem hiding this comment.
Yeah, I actually borrowed that from how cURL uses it for proxies.
About that client spec reservation point, I wasn't really sure if we had a standard for short flags yet, or if there's one planned. If -x might clash with anything down the line, I'm totally open to changing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces proxy support for network requests, allowing users to route traffic through a specified proxy server.