fix(install): wire the UserPromptSubmit prompt hook into the installer#95
Merged
Conversation
The statusline reads ~/.claude/yas-last-prompt.json to turn-scope which subagents it shows, but that marker is written by yas-prompt-hook.py which only shipped via the plugin's hooks.json — loaded only when the plugin is installed AND enabled. Installer/git-clone users (plugin disabled) got an orphan hook, so RunningSubagents.visible() silently fell back to its 60s time-window heuristic instead of accurate turn-scoping. Make ops/install.sh wire the hook the same way it already wires the statusline: resolve $PLUGIN_ROOT/hooks/yas-prompt-hook.py and upsert it into hooks.UserPromptSubmit in the same atomic write. New json_py ops wire/ get-hook/del-hook upsert by the yas-prompt-hook.py substring so foreign hooks are preserved and stale paths are rewritten on upgrade; do_uninstall removes it symmetrically, collapsing empties. Tests exercise the real heredoc via subprocess. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qvCatXxokesoY6oA2cheU
tmck-code
marked this pull request as ready for review
July 17, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The statusline reads
~/.claude/yas-last-prompt.json(or$CLAUDE_CONFIG_DIR/…) to turn-scope which subagents it shows. That marker is written byhooks/yas-prompt-hook.py, which only shipped via the plugin'shooks/hooks.json— auto-loaded by Claude Code only when the plugin is installed AND enabled.So users who install via
ops/install.sh(or git-clone) with the plugin disabled got an orphan hook: noyas-last-prompt.jsonentries, soRunningSubagents.visible()silently fell back to its 60s time-window heuristic instead of accurate turn-scoping. The statusline still rendered (installer wires it directly), so the degradation was invisible.Changes
Installer wires the hook (
ops/install.sh)json_pyopswire/get-hook/del-hook.do_wire()resolves$PLUGIN_ROOT/hooks/yas-prompt-hook.pyand upserts it intohooks.UserPromptSubmitin the same atomic write as the statusLine (one backup/validate/restore).yas-prompt-hook.pysubstring, so foreign hooks are preserved and stale paths are rewritten on upgrade (rides the same re-run rails as the statusLine path).do_uninstall()removes the hook symmetrically, collapsing emptyUserPromptSubmit/hooks.Tests (
test/test_prompt_hook.py)TestInstallerHookOpsdrives the real heredoc via subprocess: wire-on-empty, idempotent, preserve-foreign, stale-path-replace, get-hook, del-hook.Docs (
README.md)Checklist
Screenshots / recording
Benchmark
System info
🤖 Generated with Claude Code