[qtmozembed] Disconnect inactive web page from draw overlay#150
Open
rainemak wants to merge 1 commit intotmeshkova:masterfrom
Open
[qtmozembed] Disconnect inactive web page from draw overlay#150rainemak wants to merge 1 commit intotmeshkova:masterfrom
rainemak wants to merge 1 commit intotmeshkova:masterfrom
Conversation
Collaborator
There was a problem hiding this comment.
Here could be an else clause with the disconnect statement moved from above.
Contributor
Author
There was a problem hiding this comment.
setWindow and connecting again would add another connection then. Has like that while doing this. It's just safer to disconnect first and connect only if active.
Collaborator
There was a problem hiding this comment.
The line 185 makes sure that this condition is checked only if mActive changes its value, so it's unlikely that connect is called twice when setActive(true) is called twice as well. But yes, for the sake of readability it's safer to try to disconnect always.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're not rendering inactive web pages. Thus, window level draw overlay should not trigger onDrawOverlay handler for inactive pages => let's disconnect always when activity changes and enable connection only if we're activating.