fix: migrate deprecated PCFSoftShadowMap to PCFShadowMap - #11
Merged
Conversation
PCFSoftShadowMap (2) was deprecated in favor of PCFShadowMap (1), which now applies the same soft filtering. Migrate stale editor configs and project JSONs, update the examples, and add a regression test so old scenes stop emitting the WebGLShadowMap deprecation warning. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Software WebGL can take longer than a fixed 1s to draw the first frame for an OffscreenCanvas worker, which made the manual-security suite intermittently fail with a blank-canvas assertion on CI. Poll the screenshot until the scene is visibly rendered before asserting. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PCFSoftShadowMap(2) is deprecated in favor ofPCFShadowMap(1), which now applies the same soft shadow filtering. This removes the runtimeWebGLShadowMap: PCFSoftShadowMap has been deprecatedwarning at every source.Changes
editor/js/Config.js): rewrite staleshadowType: 2saved in localStorage to1on load.editor/js/libs/app.js,editor/js/Menubar.Render.js): newgetShadowMapType()helper migrates2 → 1before applying it to a renderer, covering old/published project JSONs.FOUR.PCFSoftShadowMapwithFOUR.PCFShadowMapin the WebGL manual example and 9 WebGPU examples.test/unit/editor/app.tests.js,test/unit/four.editor.unit.js,test/unit/UnitTestsEditor.html) plustest-unit-editornpm scripts.Verification
npm run test-unit-editor→ 2 passed, 0 failednpx eslintpasses on all changed files