Fix parser pad token handling and add loss mask tests#5
Open
guojasonliu wants to merge 1 commit intotogethercomputer:mainfrom
Open
Fix parser pad token handling and add loss mask tests#5guojasonliu wants to merge 1 commit intotogethercomputer:mainfrom
guojasonliu wants to merge 1 commit intotogethercomputer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unk_token_idwhenpad_token_id is None.last_turn_only, and truncation.Motivation
Aurora builds draft-model training targets from parsed conversation traces. The assistant
loss_maskdetermines which tokens contribute to the training signal. Treating token id0as missing can change behavior for tokenizers that validly use0as padding.Testing
python3 -m pytest tests/test_parse.py -qpython3 -m ruff check aurora/data/parse.py tests/test_parse.pypython3 -m ruff format --check aurora/data/parse.py tests/test_parse.py