Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example tls-graceful-shutdown to axum 0.7 #2384

Closed
wants to merge 1 commit into from

Conversation

erebe
Copy link
Contributor

@erebe erebe commented Nov 30, 2023

Following #2356, the PR update the example tls-graceful-shutdown to support axum 0.7

P.s: I don't think it would be too much work/difficult to provide directly an axum::servce_with_shutdown method

@erebe erebe mentioned this pull request Nov 30, 2023
11 tasks
@erebe erebe force-pushed the main branch 4 times, most recently from 5ed4f52 to 1d73c6f Compare November 30, 2023 08:46
@erebe
Copy link
Contributor Author

erebe commented Dec 4, 2023

Let me know if something is not right or need to changed

@hanusek
Copy link

hanusek commented Dec 6, 2023

Hello Contributors!
Can you do a code review and merge it?

@erebe
Copy link
Contributor Author

erebe commented Dec 12, 2023

Closing, as it will be updated with #2398 I suppose.
If I understand correctly, this PR is not shutting down the keep-alive of the connection. So they may never terminate.

@erebe erebe closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants