Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more must_use attributes #2846

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add more must_use attributes #2846

merged 2 commits into from
Sep 11, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Jul 24, 2024

… so people get a warning when they accidentally add a semicolon after the response expression in a handler function.

Inspired by #2845.

Screenshot_2024-07-24_225933

@jplatte jplatte force-pushed the jplatte/into-response-must-use branch from 078b707 to 3b5fffa Compare July 24, 2024 21:00
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

… so people get a warning when they accidentally add a semicolon after
the response expression in a handler function.
@jplatte jplatte force-pushed the jplatte/into-response-must-use branch from 732aafd to 5788a70 Compare September 11, 2024 19:13
@jplatte jplatte enabled auto-merge (squash) September 11, 2024 19:14
@jplatte jplatte merged commit b214e39 into main Sep 11, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/into-response-must-use branch September 11, 2024 19:17
jplatte added a commit that referenced this pull request Sep 12, 2024
… so people get a warning when they accidentally add a semicolon after the response expression in a handler function.

Also update changelogs of axum-core, axum-extra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants