Clarify some subtleties of routing #2896
Open
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mladedav
reviewed
Sep 2, 2024
jplatte
reviewed
Sep 20, 2024
Comment on lines
+86
to
+87
| paths `/foo` or `/foo/`, a nested router at `/foo` will match the path `/foo` | ||
| (but not `/foo/`), and a nested router at `/foo/` will match the path `/foo/` |
There was a problem hiding this comment.
I'm skeptical about a different bit here: A nested router at /foo will not match /foo/ (first parenthesis)? I'm pretty sure that's not right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was confused when using Axum of the following things:
nest("/foo")will match/fooand/or/foo/;fallbackis called when the method is not allowed.Solution
Document the behaviours.
Also relevant: #2659, #2251