Avoid extraneous call to remaining in get_u8/i8 #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a chained datastructure that can dereference into a slice quite fast, but remaining requires walking the chain, which is relatively slow. I would hazard a guess that this is the more common perf characteristic of non-contiguous impls of Buf. Separately, this brings these impls in line with all the other get_ impls, which have a fast path with [u8].get(...), which does the same bounds check that I do in this patch I think clippy will say to use non_empty, here, I think in this case this is more clear, but I will do whatever is preferred.
seanmonstar
reviewed
Mar 5, 2021
| /// This function panics if there is no more remaining data in `self`. | ||
| fn get_u8(&mut self) -> u8 { | ||
| assert!(self.remaining() >= 1); | ||
| assert!(self.chunk().len() >= 1); |
There was a problem hiding this comment.
I mean, the index bounds check happens just after this, I must assume these asserts are mostly to give a better panic message. Perhaps we could just make them debug_asserts?
@carllerche you added these asserts originally, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a chained datastructure that can dereference into a slice quite fast, but remaining requires walking the chain, which is relatively slow.
I would hazard a guess that this is the more common perf characteristic of non-contiguous impls of Buf.
Separately, this brings these impls in line with all the other get_ impls, which have a fast path with [u8].get(...), which does the same bounds check that I do in this patch
I think clippy will say to use non_empty, here, I think in this case this is more clear, but I will do whatever is preferred.