Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl From<Box<[u8; _]>> for Bytes #631

Closed

Conversation

MarinPostma
Copy link

I found that this implementation was missing when I needed it.

@Darksonn
Copy link
Contributor

Thanks for the PR. Unfortunately, const generics is not available on bytes's minimum supported Rust version.

@Darksonn Darksonn closed this Sep 23, 2023
@MarinPostma
Copy link
Author

@Darksonn Do you think we can bump the msrv? 1.51 is from March 2021, which was over 2 years ago. Happy to open a PR to do that as well

@MarinPostma
Copy link
Author

It's not a blocker though; there are ways around it, I just think it's an ergonomy improvement :)

@Darksonn
Copy link
Contributor

Meh, I don't think this impl is enough justification to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants