subscriber: fix excessive padding on log messages
#3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI errors are unrelated, will be fixed with #3069. ping @hawkw @davidbarsky. |
Don't add padding to `log.*` attributes (from `log` events) which are
not outputted.
## Problem
For example this config which automatically transforms `log`-events to
`tracing` ones:
```rust
tracing_subscriber::fmt()
.with_max_level(tracing::Level::TRACE)
.init();
```
With the following log message:
```rust
log::debug!("this is a log line");
```
Prints something like:
"this is a log line \n"
## Solution
Do something like in the PrettyVisitor: add a write helper which
automatically pads every write.
kaffarell
force-pushed
the
subscriber_log_spaces
branch
from
df8c08c
to
808faf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't add padding to
log.*attributes (fromlogevents) which are not outputted.Problem
For example this config which automatically transforms
log-events totracingones:With the following log message:
Prints something like:
"this is a log line \n"
Solution
Do something like in the PrettyVisitor: add a write helper which automatically pads every write.
Note: this would also need to be backported to v0.1.x!