Skip to content

feat: split CDP multi-account reopen flow from PR 94#116

Open
cyrilxc wants to merge 3 commits into
tokyoweb3:mainfrom
cyrilxc:cdp-multi-account-reopen
Open

feat: split CDP multi-account reopen flow from PR 94#116
cyrilxc wants to merge 3 commits into
tokyoweb3:mainfrom
cyrilxc:cdp-multi-account-reopen

Conversation

@cyrilxc
Copy link
Copy Markdown
Contributor

@cyrilxc cyrilxc commented Mar 30, 2026

Description

Split from #94 to isolate CDP multi-account reopen, conversation transfer, and Antigravity discovery/process handling.

Included

  • CDP multi-account reopen/session recovery flow
  • Antigravity account discovery/process inspection
  • conversation transfer helpers
  • security hardening for manifest path validation and symlink traversal
  • minimal shared Telegram support needed for branch buildability

Verification (March 31, 2026)

  • npm run build
  • npm test -- tests/bot/telegramJoinCommand.test.ts tests/bot/telegramProjectCommand.test.ts tests/bot/telegramStartupTarget.test.ts tests/services/antigravityAccountDiscovery.test.ts tests/services/cdpService.uiSync.test.ts
  • PATH=/Users/cyrilchan/.nvm/versions/node/v22.18.0/bin:$PATH node ./node_modules/jest/bin/jest.js tests/services/conversationTransferService.test.ts --runInBand

Related

Notes

  • Local SQLite-backed Jest suites require forcing PATH to the nvm Node binary so Jest uses the same ABI (127) as the rebuilt better-sqlite3 addon.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 30, 2026

Warning

Rate limit exceeded

@cyrilxc has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 58 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 58 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18d5998f-ea0e-413d-a326-0b498d9f979a

📥 Commits

Reviewing files that changed from the base of the PR and between 743ec52 and 6819282.

📒 Files selected for processing (61)
  • src/bin/cli.ts
  • src/bin/commands/conversationTransfer.ts
  • src/bin/commands/open.ts
  • src/bin/commands/setup.ts
  • src/bot/index.ts
  • src/bot/telegramCommands.ts
  • src/bot/telegramJoinCommand.ts
  • src/bot/telegramMessageHandler.ts
  • src/bot/telegramProjectCommand.ts
  • src/bot/telegramStartupTarget.ts
  • src/commands/chatCommandHandler.ts
  • src/commands/joinCommandHandler.ts
  • src/commands/registerSlashCommands.ts
  • src/commands/workspaceCommandHandler.ts
  • src/database/accountPreferenceRepository.ts
  • src/database/channelPreferenceRepository.ts
  • src/database/chatSessionRepository.ts
  • src/database/telegramBindingRepository.ts
  • src/events/interactionCreateHandler.ts
  • src/events/messageCreateHandler.ts
  • src/handlers/accountSelectAction.ts
  • src/handlers/modelButtonAction.ts
  • src/services/antigravityAccountDiscovery.ts
  • src/services/antigravityProcessService.ts
  • src/services/cdpBridgeManager.ts
  • src/services/cdpConnectionPool.ts
  • src/services/cdpService.ts
  • src/services/chatSessionService.ts
  • src/services/conversationTransferService.ts
  • src/services/responseMonitor.ts
  • src/services/userMessageDetector.ts
  • src/ui/accountUi.ts
  • src/utils/accountUtils.ts
  • src/utils/cdpPorts.ts
  • src/utils/config.ts
  • src/utils/configLoader.ts
  • tests/bot.modelCommand.test.ts
  • tests/bot.openCommand.test.ts
  • tests/bot.projectReopen.test.ts
  • tests/bot.statusCommand.test.ts
  • tests/bot/telegramJoinCommand.test.ts
  • tests/bot/telegramMessageHandler.test.ts
  • tests/bot/telegramProjectCommand.test.ts
  • tests/bot/telegramStartupTarget.test.ts
  • tests/commands/chatCommandHandler.test.ts
  • tests/commands/registerSlashCommands.test.ts
  • tests/commands/workspaceCommandHandler.test.ts
  • tests/config.test.ts
  • tests/configLoader.test.ts
  • tests/database/chatSessionRepository.test.ts
  • tests/database/telegramBindingRepository.test.ts
  • tests/events/interactionCreateHandler.test.ts
  • tests/events/messageCreateHandler.test.ts
  • tests/services/antigravityAccountDiscovery.test.ts
  • tests/services/cdpConnectionPool.test.ts
  • tests/services/cdpService.uiSync.test.ts
  • tests/services/chatSessionService.test.ts
  • tests/services/conversationTransferService.test.ts
  • tests/ui/accountUi.test.ts
  • tests/utils/accountUtils.test.ts
  • tests/utils/cdpPorts.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tokyoweb3
Copy link
Copy Markdown
Owner

Same situation as #115 — we've merged #112, #113, #114, and #119, which creates significant overlap since they all originate from #94.

Please rebase this branch onto main after #115 is rebased and merged. The infrastructure code from #114 is already on main, so the conflicts should resolve by dropping duplicate hunks and keeping the CDP multi-account reopen additions.

git fetch upstream main
git rebase upstream/main
git push --force-with-lease

Happy to help if you run into any issues with the rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants