fix: let users uninstall the Codex plugin from the catalog - #49
Open
camjac251 wants to merge 1 commit into
Open
Conversation
The marketplace entry declared INSTALLED_BY_DEFAULT. Codex reads that as an admin-managed deployment: the plugin catalog labels the plugin "Installed by admin" and renders a disabled row in place of the uninstall action, so a user who installed GoalBuddy themselves cannot remove it from the catalog. GoalBuddy is user-installed, so the entry now declares AVAILABLE, which is also the enum's default. The authentication policy stays ON_INSTALL, likewise the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Codex marketplace entry declares
"installation": "INSTALLED_BY_DEFAULT". Codex reads that as an admin-managed deployment, so the plugin catalog labels GoalBuddy "Installed by admin" and renders a disabled row in place of the uninstall action. A user who installed GoalBuddy themselves cannot remove it from the catalog.This changes the entry to
"AVAILABLE", which is also the enum's default.Evidence
codex-rs/tui/src/chatwidget/plugin_catalog.rsbuilds the action row:The same policy also drives the "Admin assigned" and "Enabled by Admin" labels elsewhere in the catalog. It does not trigger auto-install anywhere in core, so the current value buys nothing and costs the uninstall action.
MarketplacePluginInstallPolicyincodex-rs/core-plugins/src/marketplace.rsmarksAvailableas#[default]."authentication": "ON_INSTALL"is left as is: that is also its enum default.Test plan
npm run checkpasses (109 internal tests).AVAILABLEis correct.