Bugfix: Allow both Read and Write if both are present in the scope#1
Open
jpoissant wants to merge 1 commit intotom-smith-okta:masterfrom
Open
Bugfix: Allow both Read and Write if both are present in the scope#1jpoissant wants to merge 1 commit intotom-smith-okta:masterfrom
jpoissant wants to merge 1 commit intotom-smith-okta:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: if you provide both read and write scope
api:read api:writeonly theGETmethod would be allowed.Fix: Change the
else ifto anifwhen checking forapi:writein the scp