Closed
Conversation
|
Size Change: +188 B (+6.1%) 🔍 Total Size: 3.27 kB
ℹ️ View Unchanged
|
Coverage Report
File CoverageNo changed files found. |
0b44fd2 to
a5c09c1
Compare
4cfb79e to
e66aa64
Compare
da8b96a to
5e44e92
Compare
|
| Branch | push-vwzxzqtonxov |
| Testbed | gha |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| table/large/activate | heap megabytes (MB) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 5.88 MB(-24.14%)Baseline: 7.75 MB | 5.99 MB (101.82%) |
Click to view all benchmark results
| Benchmark | duration | Benchmark Result microseconds (µs) (Result Δ%) | Lower Boundary microseconds (µs) (Limit %) | heap | Benchmark Result bytes (B) (Result Δ%) | Lower Boundary bytes (B) (Limit %) |
|---|---|---|---|---|---|---|
| anim/large/advance | 📈 view plot 🚷 view threshold | 9,782.59 µs(-18.86%)Baseline: 12,056.34 µs | 7,244.06 µs (74.05%) | 📈 view plot 🚷 view threshold | 3,446,447.76 B(+8.55%)Baseline: 3,175,060.62 B | 2,501,754.68 B (72.59%) |
| anim/small/advance | 📈 view plot 🚷 view threshold | 4,111.07 µs(-15.12%)Baseline: 4,843.24 µs | 3,477.96 µs (84.60%) | 📈 view plot 🚷 view threshold | 1,067,593.14 B(+4.12%)Baseline: 1,025,386.87 B | 781,916.10 B (73.24%) |
| table/large/activate | 📈 view plot 🚷 view threshold | 29,477.93 µs(+5.33%)Baseline: 27,985.27 µs | 23,935.50 µs (81.20%) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 5,880,366.55 B(-24.14%)Baseline: 7,751,858.38 B | 5,987,248.69 B (101.82%) |
| table/large/filter | 📈 view plot 🚷 view threshold | 92,919.10 µs(+57.06%)Baseline: 59,163.00 µs | 16,741.92 µs (18.02%) | 📈 view plot 🚷 view threshold | 14,906,088.73 B(+55.55%)Baseline: 9,582,779.11 B | 3,586,250.29 B (24.06%) |
| table/large/removeAll | 📈 view plot 🚷 view threshold | 65,870.91 µs(+49.95%)Baseline: 43,928.24 µs | 12,501.88 µs (18.98%) | 📈 view plot 🚷 view threshold | 10,206,822.40 B(+28.00%)Baseline: 7,973,959.94 B | 2,239,483.17 B (21.94%) |
| table/large/render | 📈 view plot 🚷 view threshold | 33,620.21 µs(+21.71%)Baseline: 27,624.05 µs | 20,302.82 µs (60.39%) | 📈 view plot 🚷 view threshold | 10,573,069.47 B(+18.72%)Baseline: 8,905,877.49 B | 6,420,236.78 B (60.72%) |
| table/large/sort | 📈 view plot 🚷 view threshold | 85,035.17 µs(+52.73%)Baseline: 55,676.85 µs | 16,123.32 µs (18.96%) | 📈 view plot 🚷 view threshold | 10,600,903.11 B(+47.10%)Baseline: 7,206,739.37 B | 2,651,166.61 B (25.01%) |
| table/small/activate | 📈 view plot 🚷 view threshold | 3,010.94 µs(+14.54%)Baseline: 2,628.76 µs | 2,180.74 µs (72.43%) | 📈 view plot 🚷 view threshold | 1,441,185.19 B(+56.78%)Baseline: 919,227.96 B | 401,731.03 B (27.88%) |
| table/small/filter | 📈 view plot 🚷 view threshold | 5,557.13 µs(+33.55%)Baseline: 4,160.98 µs | 2,330.20 µs (41.93%) | 📈 view plot 🚷 view threshold | 1,976,407.52 B(+75.92%)Baseline: 1,123,460.70 B | 203,159.11 B (10.28%) |
| table/small/removeAll | 📈 view plot 🚷 view threshold | 4,221.26 µs(+26.09%)Baseline: 3,347.75 µs | 1,880.12 µs (44.54%) | 📈 view plot 🚷 view threshold | 798,179.02 B(+56.58%)Baseline: 509,771.39 B | -79,506.71 B (-9.96%) |
| table/small/render | 📈 view plot 🚷 view threshold | 3,210.65 µs(+0.91%)Baseline: 3,181.77 µs | 2,411.67 µs (75.11%) | 📈 view plot 🚷 view threshold | 1,199,706.92 B(+45.91%)Baseline: 822,235.17 B | 381,007.99 B (31.76%) |
| table/small/sort | 📈 view plot 🚷 view threshold | 6,019.02 µs(+39.89%)Baseline: 4,302.59 µs | 2,003.96 µs (33.29%) | 📈 view plot 🚷 view threshold | 1,068,229.28 B(+45.60%)Baseline: 733,694.19 B | 245,931.06 B (23.02%) |
| tree/large/removeAll | 📈 view plot 🚷 view threshold | 2,935.94 µs(-18.45%)Baseline: 3,600.17 µs | 2,450.74 µs (83.47%) | 📈 view plot 🚷 view threshold | 1,071,066.76 B(+4.20%)Baseline: 1,027,863.49 B | 852,565.29 B (79.60%) |
| tree/large/render | 📈 view plot 🚷 view threshold | 2,789.72 µs(-13.09%)Baseline: 3,209.94 µs | 2,585.59 µs (92.68%) | 📈 view plot 🚷 view threshold | 1,188,648.65 B(+10.57%)Baseline: 1,074,976.75 B | 840,386.46 B (70.70%) |
| tree/large/reverse | 📈 view plot 🚷 view threshold | 3,866.44 µs(-9.91%)Baseline: 4,291.85 µs | 3,254.58 µs (84.17%) | 📈 view plot 🚷 view threshold | 1,110,334.85 B(+23.39%)Baseline: 899,852.08 B | 579,545.66 B (52.20%) |
| tree/small/insertFirst | 📈 view plot 🚷 view threshold | 560.54 µs(-10.19%)Baseline: 624.15 µs | 487.31 µs (86.94%) | 📈 view plot 🚷 view threshold | 210,145.69 B(+13.53%)Baseline: 185,099.11 B | 141,292.41 B (67.24%) |
| tree/small/insertLast | 📈 view plot 🚷 view threshold | 531.14 µs(-8.63%)Baseline: 581.33 µs | 439.57 µs (82.76%) | 📈 view plot 🚷 view threshold | 196,591.21 B(+13.06%)Baseline: 173,883.77 B | 131,398.57 B (66.84%) |
| tree/small/moveFromEndToStart | 📈 view plot 🚷 view threshold | 522.72 µs(-5.89%)Baseline: 555.42 µs | 421.66 µs (80.67%) | 📈 view plot 🚷 view threshold | 126,303.42 B(+10.50%)Baseline: 114,303.62 B | 89,291.39 B (70.70%) |
| tree/small/moveFromStartToEnd | 📈 view plot 🚷 view threshold | 536.81 µs(-7.30%)Baseline: 579.08 µs | 441.83 µs (82.31%) | 📈 view plot 🚷 view threshold | 157,374.81 B(+12.37%)Baseline: 140,054.78 B | 109,347.84 B (69.48%) |
| tree/small/no_change | 📈 view plot 🚷 view threshold | 386.36 µs(-11.05%)Baseline: 434.36 µs | 368.55 µs (95.39%) | 📈 view plot 🚷 view threshold | 155,737.80 B(+10.90%)Baseline: 140,431.35 B | 111,851.63 B (71.82%) |
| tree/small/removeAll | 📈 view plot 🚷 view threshold | 430.06 µs(-20.53%)Baseline: 541.19 µs | 339.03 µs (78.83%) | 📈 view plot 🚷 view threshold | 165,919.47 B(+7.47%)Baseline: 154,380.37 B | 128,162.46 B (77.24%) |
| tree/small/removeFirst | 📈 view plot 🚷 view threshold | 540.52 µs(-10.36%)Baseline: 602.97 µs | 464.05 µs (85.85%) | 📈 view plot 🚷 view threshold | 153,090.58 B(+11.55%)Baseline: 137,245.17 B | 110,231.85 B (72.00%) |
| tree/small/removeLast | 📈 view plot 🚷 view threshold | 446.42 µs(-7.66%)Baseline: 483.44 µs | 397.35 µs (89.01%) | 📈 view plot 🚷 view threshold | 146,004.25 B(+12.67%)Baseline: 129,591.06 B | 101,207.59 B (69.32%) |
| tree/small/render | 📈 view plot 🚷 view threshold | 533.89 µs(-3.84%)Baseline: 555.24 µs | 481.13 µs (90.12%) | 📈 view plot 🚷 view threshold | 161,619.93 B(+0.45%)Baseline: 160,901.22 B | 142,500.67 B (88.17%) |
| tree/small/reverse | 📈 view plot 🚷 view threshold | 539.41 µs(-9.29%)Baseline: 594.66 µs | 451.83 µs (83.76%) | 📈 view plot 🚷 view threshold | 143,070.87 B(+15.50%)Baseline: 123,869.33 B | 85,026.97 B (59.43%) |
| tree/worst_case/kivi | 📈 view plot 🚷 view threshold | 1,138.85 µs(+3.88%)Baseline: 1,096.36 µs | 741.50 µs (65.11%) | 📈 view plot 🚷 view threshold | 290,127.36 B(+16.07%)Baseline: 249,950.06 B | 173,797.05 B (59.90%) |
| tree/worst_case/react | 📈 view plot 🚷 view threshold | 1,243.79 µs(+15.73%)Baseline: 1,074.78 µs | 552.23 µs (44.40%) | 📈 view plot 🚷 view threshold | 315,713.72 B(+18.22%)Baseline: 267,065.93 B | 178,853.52 B (56.65%) |
| tree/worst_case/snabbdom | 📈 view plot 🚷 view threshold | 974.38 µs(-8.80%)Baseline: 1,068.35 µs | 803.97 µs (82.51%) | 📈 view plot 🚷 view threshold | 274,555.93 B(+15.34%)Baseline: 238,043.96 B | 170,926.50 B (62.26%) |
| tree/worst_case/virtual_dom | 📈 view plot 🚷 view threshold | 939.28 µs(-9.54%)Baseline: 1,038.39 µs | 792.91 µs (84.42%) | 📈 view plot 🚷 view threshold | 293,096.86 B(+23.60%)Baseline: 237,136.65 B | 155,946.58 B (53.21%) |
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/server.ts:227
- [nitpick] The name 'RecursivePromise' may be misleading since it is not used recursively; consider renaming it to 'WrappedPromise' or another name that clearly reflects its purpose.
type RecursivePromise<T> = Promise<{
src/server.ts:246
- [nitpick] Both renderToString and renderToReadableStream use similar looping logic over renderable parts; consider refactoring the common functionality into a shared helper to reduce duplication and prevent potential inconsistencies.
export async function renderToString(value: Displayable): Promise<string> {
src/server.ts:261
- The assertion checking that no new injections were added during injection processing suggests that dynamic injections are not supported; if this behavior is intended, consider adding documentation or handling for scenarios where injections may be appended asynchronously.
count === renderController.injections.length,
f7fb116 to
72e704f
Compare
f6c735c to
6a64dfc
Compare
6cc0637 to
eae2de0
Compare
12abb48 to
3533e0c
Compare
5c4ef61 to
662c4b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.