Skip to content

chore: changes to yarn#305

Merged
krigga merged 2 commits into
ton-org:developfrom
Danil42Russia:danil42russia/eslint
Dec 4, 2025
Merged

chore: changes to yarn#305
krigga merged 2 commits into
ton-org:developfrom
Danil42Russia:danil42russia/eslint

Conversation

@Danil42Russia

@Danil42Russia Danil42Russia commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Issue

  1. yarnPath is an outdated installation method; even developers recommend using corepack.
    Quote from the documentation:
    The yarnPath setting used to be the preferred way to install Yarn within a project, but we now recommend to use [Corepack](https://nodejs.org/api/corepack.html) in most cases.
    
  2. there is no point in using enableGlobalCache and compressionLevel, because you are not using zero-installs
  3. set enableScripts to false so that postinstall scripts can be executed.

Checklist

Please ensure the following items are completed before requesting review:

  • Updated CHANGELOG.md with relevant changes
  • Documented the contribution in README.md
  • Added tests to demonstrate correct behavior (both positive and negative cases)
  • All tests pass successfully (yarn test)
  • Code passes linting checks (yarn lint)

@Danil42Russia

Copy link
Copy Markdown
Contributor Author

The only thing preventing the pipeline from being green is the action the-ton-tech/toolchain/lint@v1.4.0. It uses infrastructure for 1 yarn, but the project uses 2.

This raises the question: is this action really necessary?

@krigga

krigga commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

We'll take a look at the action and might merge the PR then

@Danil42Russia

Copy link
Copy Markdown
Contributor Author

I made an update to the-ton-tech/toolchain#7 so that this MR could be completed.

Comment thread .github/workflows/publish-dev.yml
@krigga
krigga dismissed TrueCarry’s stale review December 4, 2025 06:47

The change was done

@krigga
krigga merged commit 3a66f16 into ton-org:develop Dec 4, 2025
4 checks passed
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown

🎉 @Danil42Russia, your reward is ready! Claim it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants