API Enhancements #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 28, 2018 11:39
* BleApplicationListener.deviceConnected and BleApplicationListener.deviceDisconnected now have a path parameter. The path that is assigned by BlueZ D-Bus for the remote device that connected to the local Bluetooth adapter. deviceConnected also provides the unique Bluetooth Address of the remote Bluetooth Device. * BleCharacteristicListener.getValue and setValue now take a devicePath. If more than one device is connected to the characteristic, the correct one will read/receive the value. * BleCharacteristic.sendNotification now has a devicePath parameter to the notification can be sent to the proper device if multiple devices are listening. * BleCharacteristic now implements a getValue and setValue that can be overridden as an alternative to using the listener. * Created BleAdapter utility object to consolidate information about the local Bluetooth Adapter * Changed BleApplicaton.findAdapterPath to return the object * Added BleApplication.getBleAdapter method to return the Adapter currently being used by the BleApplication * Updated ExampleMain and ExampleCharacteristic to test and demonstrate the above changes. * Updated the build.gradle file so that it would work with more systems and IDEs. * Added runExample target in the build.gradle so that the example can be more easily run on the command line * Added example.conf to allow the example to run without elevated permissions * Added instructions to run the example from the command line and for the example.conf to README.md * Suggested using ./gradlew rather than requiring the user to install a specific version of Gradle. https://docs.gradle.org/current/userguide/gradle_wrapper.html * Fixed install instructions in READEME.md * General wordsmithing of the README.md * Added JetBrains IntilliJ project files to the .gitignore
* put java-library back * using implementation instead of compile to match latest version of gradle * fixed spelling error in method name.
|
👍 Can we merge this PR? |
|
FYI: https://github.com/magillus/ble-java I merged both forks and added some extra logging info - per #12 |
* Updated to Gradle 5.6.2 - Compatible with Java 11 (OpenJDK) * PUt sleeps back in the ExampleMain for testing # Conflicts: # .gitignore # src/main/java/it/tangodev/ble/BleApplication.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes we talked about. Mostly, it passes a little more information about the connection up to the calling app. This includes the BT Address and D-Bus Path of the local Bluetooth adapter and the connecting adapters.
The build.gradle was updated to run on Ubuntu and Raspbian and a runExample target was added.
The README.md was updated to reflect the changes.