Skip to content

fix(PM-1310): show types propertly in opportunity details page #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

hentrymartin
Copy link
Collaborator

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-1310

What's in this PR?

  • Show types properly in opportunity details page

case 'datascience':
return ProjectType.datascience
case 'dev':
return ProjectType.developement

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: 'developement' should be corrected to 'development'.

<span
className={styles.infoValue}
>
{opportunity?.type && getOpportunityType(opportunity?.type)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if getOpportunityType function handles all possible values of opportunity?.type to avoid unexpected results or errors. If getOpportunityType can return null or undefined, ensure that the UI handles these cases gracefully.

@hentrymartin hentrymartin requested a review from kkartunov June 18, 2025 15:57
@hentrymartin hentrymartin merged commit 86575bb into dev Jun 19, 2025
3 checks passed
@hentrymartin hentrymartin deleted the pm-1310 branch June 19, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants