fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation #1116

hentrymartin · 2025-06-19T13:29:15Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-1373
https://topcoder.atlassian.net/browse/PM-1375
https://topcoder.atlassian.net/browse/PM-1376
https://topcoder.atlassian.net/browse/PM-1383
https://topcoder.atlassian.net/browse/PM-1380
https://topcoder.atlassian.net/browse/PM-1378

What's in this PR?

Removed existing copilot related question
Added duration in opportunity list
Rephrased apply modal copy
Added cancel copilot opportunity button in details page
Fixed some design inconsistencies
Fixed an issue in applications list page

github-actions · 2025-06-19T13:29:28Z

...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx

-                            to providing a seamless and efficient process to ensure a 
-                            great experience for all copilots. We will review your application 
-                            within short time.`
+                            ? `Thank you for taking the time to apply for this exciting opportunity. We truly value your interest and effort. Your application will be reviewed promptly.`


Consider using a more formal tone by replacing 'promptly' with 'in a timely manner' to maintain consistency with the rest of the message.

github-actions · 2025-06-19T13:29:28Z

...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx

                            ensure that you have carefully reviewed the project requirements and 
-                            are committed to meeting them.`
+                            are committed to meeting them. Please write below the reason(s) why you believe you're a good fit for this project (e.g., previous experience, availability, etc.).`


The phrase 'Please write below the reason(s)' could be more concise. Consider rephrasing to 'Please provide the reason(s)'.

github-actions · 2025-06-19T13:29:29Z

...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx

                    }
                </div>
                {
                    !success && (
                        <InputTextarea
-                            name='Notes'
+                            name='Reason'


The input field name has been changed from 'Notes' to 'Reason'. Ensure that this change is reflected consistently throughout the codebase, including any form handling logic or validation that may rely on the field name.

github-actions · 2025-06-19T15:48:25Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -28,6 +28,7 @@ import { textFormatDateLocaleShortString } from '~/libs/shared'

 import { CopilotApplication } from '../../models/CopilotApplication'
 import {
+    cancelCopilotOpportunity,


The function cancelCopilotOpportunity is imported but not used in this file. Consider removing it if it's not needed.

github-actions · 2025-06-19T15:48:27Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -119,11 +120,25 @@ const CopilotOpportunityDetails: FC<{}> = () => {
        )
    }

+    async function cancelCopilotOpportunityHandler() {


Consider adding error handling for the cancelCopilotOpportunityHandler function to manage potential failures from the cancelCopilotOpportunity API call.

github-actions · 2025-06-19T15:48:28Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

+    async function cancelCopilotOpportunityHandler() {
+        if (opportunityId) {
+            await cancelCopilotOpportunity(opportunityId)
+            mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`)


The mutate function is called twice with similar URLs. Consider extracting the base URL and opportunity ID into a variable to avoid repetition and improve readability.

github-actions · 2025-06-19T15:48:30Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -136,6 +151,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
                && opportunity?.status === 'active'
                && opportunity?.canApplyAsCopilot ? applyCopilotOpportunityButton : undefined
            }
+            secondaryButtonConfig={opportunity?.status === 'active' && isAdminOrPM ? cancelCopilotOpportunityButton : undefined}


Consider checking if isAdminOrPM is defined and has a valid value before using it in the conditional expression to avoid potential runtime errors.

github-actions · 2025-06-19T15:48:34Z

src/apps/copilots/src/pages/copilot-opportunity-details/styles.module.scss

@@ -1,5 +1,9 @@
 @import '@libs/ui/styles/includes';

+.wrapper {
+    min-height: 800px;


Consider using a more flexible unit for min-height, such as vh or %, to ensure better responsiveness across different screen sizes.

github-actions · 2025-06-19T15:48:37Z

...src/pages/copilot-opportunity-details/tabs/copilot-applications/CopilotApplicationAction.tsx

@@ -15,7 +15,7 @@ const CopilotApplicationAction = (
 ): JSX.Element => {
    const { opportunityId }: {opportunityId?: string} = useParams<{ opportunityId?: string }>()
    const isInvited = useMemo(
-        () => allCopilotApplications.findIndex(item => item.status === CopilotApplicationStatus.INVITED) > -1,
+        () => allCopilotApplications && allCopilotApplications.findIndex(item => item.status === CopilotApplicationStatus.INVITED) > -1,


Consider using optional chaining (?.) for safer access to allCopilotApplications. This can prevent potential runtime errors if allCopilotApplications is null or undefined. For example: allCopilotApplications?.findIndex(...).

github-actions · 2025-06-19T15:48:41Z

...pilots/src/pages/copilot-opportunity-details/tabs/opportunity-details/OpportunityDetails.tsx

-                        {skill.name}
-                    </div>
-                ))}
+                {props.opportunity?.skills.map(item => item.name).join(",")}


The current implementation concatenates skill names into a single string separated by commas. This change removes the previous styling applied to each skill using styles.skillPill. If the styling is still required, consider mapping over the skills to create individual styled elements instead of joining them into a single string.

github-actions · 2025-06-19T16:00:18Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

+                            <span
+                                className={styles.infoValue}
+                            >
+                              {opportunity?.type && getOpportunityType(opportunity?.type)}


The function getOpportunityType is used here to transform opportunity?.type. Ensure that this function handles all possible values of opportunity?.type and returns a meaningful result or a default value if the type is not recognized.

github-actions · 2025-06-19T18:27:11Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -47,6 +48,7 @@ import {
 import { OpportunityDetails } from './tabs/opportunity-details'
 import { CopilotApplications } from './tabs/copilot-applications'
 import styles from './styles.module.scss'
+import { toast } from 'react-toastify'


It seems that toast from react-toastify is imported but not used in this file. Consider removing the import if it is not needed to keep the code clean and avoid unnecessary dependencies.

github-actions · 2025-06-19T18:27:13Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

@@ -104,7 +106,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {

    const onApplied: () => void = useCallback(() => {
        mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`)
-        mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}`)
+        mutate(`${copilotBaseUrl}/copilot/opportunity/${opportunityId}`)


The URL path has been changed from 'copilots/opportunity' to 'copilot/opportunity'. Please ensure that this change is intentional and that the new path is correct and consistent with the API endpoint.

github-actions · 2025-06-19T18:27:16Z

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

+        if (opportunityId) {
+            await cancelCopilotOpportunity(opportunityId)
+            mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`)
+            mutate(`${copilotBaseUrl}/copilot/opportunity/${opportunityId}`)


The URL path in the mutate function call has been changed from copilots to copilot. Ensure that this change is intentional and that the new path is correct, as it might affect the data fetching logic.

fix: demo feedbacks implementation

cd48385

hentrymartin requested a review from kkartunov June 19, 2025 13:29

github-actions bot reviewed Jun 19, 2025

View reviewed changes

hentrymartin added 2 commits June 19, 2025 19:00

fix: lint

0393ba4

feat: added cancel opportunity button and some design changes

2001031

github-actions bot reviewed Jun 19, 2025

View reviewed changes

fix: lint

ce59d56

hentrymartin changed the title ~~fix(PM-1373, PM-1375, PM-1376): demo feedbacks implementation~~ fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation Jun 19, 2025

kkartunov approved these changes Jun 19, 2025

View reviewed changes

Merge branch 'dev' into pm-1373

389903d

github-actions bot reviewed Jun 19, 2025

View reviewed changes

hentrymartin added 2 commits June 19, 2025 21:33

fix: lint

d67e59e

fix: refetch opportunity details on canceling opportunity

9b6c7bc

github-actions bot reviewed Jun 19, 2025

View reviewed changes

fix: refetch opportunity details on canceling opportunity

cca9941

hentrymartin merged commit 296bbcf into dev Jun 19, 2025
3 checks passed

hentrymartin deleted the pm-1373 branch June 19, 2025 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation #1116

fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation #1116

Uh oh!

hentrymartin commented Jun 19, 2025 •

edited

Loading

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

github-actions bot Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation #1116

fix(PM-1373, PM-1375, PM-1376, PM-1383, PM-1380, PM-1378): demo feedbacks implementation #1116

Uh oh!

Conversation

hentrymartin commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related JIRA Ticket:

What's in this PR?

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hentrymartin commented Jun 19, 2025 •

edited

Loading