Skip to content

Fix sortOrder for scorecardQuestions & make error more visible #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix sortOrder for scorecardQuestions & make error more visible #1203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d3098
Fix sortOrder for scorecardQuestions & make error more visible
vas3a Aug 21, 2025
3c12410
lint fixes
vas3a Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/apps/review/src/pages/scorecards/EditScorecardPage/EditScorecardPage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@
.headerArea {
background: #0F172A;
color: $tc-white;

:global(.input-error) {
font-family: "Nunito Sans", sans-serif;
background: #E2CBC0;
width: max-content;
padding: 0 $sp-2;
border-radius: 2px;
font-size: 14px;
line-height: 20px;
font-weight: bold;
}
}

.contentArea {
Expand All @@ -103,6 +114,17 @@
.headerArea {
background: $teal-160;
color: $tc-white;

:global(.input-error) {
font-family: "Nunito Sans", sans-serif;
background: #E2CBC0;
width: max-content;
padding: 0 $sp-2;
border-radius: 2px;
font-size: 14px;
line-height: 20px;
font-weight: bold;
}
}

.contentArea {
Expand Down
4 changes: 2 additions & 2 deletions src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardQuestionForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const ScorecardQuestionForm: FC<ScorecardQuestionFormProps> = props => {

const handleRemove = useCallback(async (index: number, field: any) => {
if (!await ctx.confirm({
content: `Are you sure you want to remove "${field.name ? field.name : `Question ${index + 1}`}" question?`,
content: `Are you sure you want to remove "${field.name ? field.name : `Question ${props.sectionIndex}.${index + 1}`}" question?`,
title: 'Confirm Remove Question',
})) {
return
Expand All @@ -82,7 +82,7 @@ const ScorecardQuestionForm: FC<ScorecardQuestionFormProps> = props => {
const handleAddQuestion = useCallback(() => {
formQuestionsArray.append({
...getEmptyScorecardQuestion(),
sortOrder: Math.max(...formQuestionsArray.fields.map(f => get(f, 'sortOrder', 0))) + 1,
sortOrder: (Math.max(0, ...formQuestionsArray.fields.map(f => get(f, 'sortOrder', 0))) || 0) + 1,
})
}, [formQuestionsArray])

Expand Down