PM-1105 - Checkpoint winners #105
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| generateWinnersPayments(challenge: Challenge): PaymentPayload[] { | ||
| const { prizeSets, winners } = challenge; | ||
|
|
||
| generateWinnersPayments( |
There was a problem hiding this comment.
[correctness]
The function signature has been changed to accept winners and prizes as separate parameters, but the original challenge parameter already contains these properties. This change could lead to redundancy and potential inconsistencies if the winners or prizes parameters differ from those in the challenge object. Consider using the properties directly from the challenge object to maintain consistency and reduce the risk of errors.
| 'desc', | ||
| ); | ||
|
|
||
| if ((checkpointPrizes?.length ?? 0) < (checkpointWinners?.length ?? 0)) { |
There was a problem hiding this comment.
[maintainability]
The error message could be more informative by including the actual numbers of checkpoint winners and prizes. Consider including these values to aid debugging.
| ); | ||
| } | ||
|
|
||
| if (!checkpointPrizes?.length) { |
There was a problem hiding this comment.
[💡 maintainability]
The check for !checkpointPrizes?.length is redundant since the previous condition already ensures that checkpointPrizes has at least as many elements as checkpointWinners. Consider removing this check to simplify the code.
| overview: PrizeOverview; | ||
| winners: Winner[]; // Replace with type if needed | ||
| winners: Winner[]; | ||
| checkpointWinners: Winner[]; |
There was a problem hiding this comment.
[correctness]
Consider adding validation or constraints to ensure that checkpointWinners is correctly populated and does not contain duplicates or invalid entries. This will help maintain data integrity and prevent potential issues with incorrect winner data.
2 participants
https://topcoder.atlassian.net/browse/PM-1105 - handle challenge checkpoint winners