PM-1213 - handle insufficient funds errors #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/shared/global/trolley.service.ts
Outdated
|
|
||
| this.logger.debug(`Created payment with id ${payment.id}`); | ||
|
|
||
| return paymentBatch; | ||
| } catch (e) { | ||
| this.logger.error(`Failed to create payment, error '${e.message}'!`); | ||
| console.log(e); |
There was a problem hiding this comment.
Using console.log(e); for error logging is not recommended in production code. Consider using a more robust logging mechanism or removing this line if it's not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call
.startProcessing()on trolley, we'll get an "insufficient funds" error.this was breaking the payment flow before (I wasn't expecting an error at this point, I was expecting a payment failed event). Anyway. we don't need to do anything if such error occurs. everything proceeds as expected: create the payment & mark it as "processing".
When funds are added to trolley, admin can approve & finish the payment and everything works as expected.