add missing method #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| async removePayment(paymentId: string, batchId: string) { | ||
| try { | ||
| await this.client.payment.remove(paymentId, batchId); |
There was a problem hiding this comment.
[correctness]
Consider adding a check to ensure paymentId and batchId are valid before attempting to remove the payment. This can prevent unnecessary operations and potential errors if the IDs are invalid or undefined.
| this.logger.debug(`Removed trolley payment with id ${paymentId}`); | ||
| } catch (error) { | ||
| this.logger.error( | ||
| `Failed to remove trolley payment: '${error.message}'!`, |
There was a problem hiding this comment.
[💡 readability]
The error logging message could be improved by including more context about the operation that failed. Consider specifying the operation name in the log message to make it clearer in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.