add more logs #11
Merged
add more logs #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| headers, | ||
| }); | ||
| try { | ||
| return await fetch(stringUrl, { |
There was a problem hiding this comment.
high
correctness
The await keyword is used here, but the function is not marked as async. This will result in a syntax error. Ensure the function is declared as async to handle the await correctly.
| headers, | ||
| }); | ||
| } catch (error) { | ||
| this.logger.error(`Error fetching challenges: ${JSON.stringify(error)}`, error); |
There was a problem hiding this comment.
medium
readability
Consider using error.message instead of JSON.stringify(error) for logging the error message. JSON.stringify might not serialize the error object as expected, leading to loss of information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.