feat(vscode): updated extensions for a given profile #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Feb 8, 2025
src/config.rs
Outdated
Comment on lines
1681
to
1687
| pub fn vscode_profile(&self) -> &str { | ||
| self.config_file | ||
| .vscode | ||
| .as_ref() | ||
| .and_then(|vscode| vscode.profile.as_deref()) | ||
| .unwrap_or("") | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub fn vscode_profile(&self) -> &str { | |
| self.config_file | |
| .vscode | |
| .as_ref() | |
| .and_then(|vscode| vscode.profile.as_deref()) | |
| .unwrap_or("") | |
| } | |
| pub fn vscode_profile(&self) -> Option<&str> { | |
| let vscode_cfg = self.config_file.vscode?; | |
| let profile = vscode_cfg.profile?; | |
| // Treat empty profile as None | |
| if profile.is_empty() { | |
| None | |
| } else { | |
| profile.as_str() | |
| } | |
| } | |
There was a problem hiding this comment.
Had to make some changes to apply this suggestion. The borrow checker had some complaints.
f0d055c
src/steps/generic.rs
Outdated
Comment on lines
474
to
486
| if !ctx.config().vscode_profile().is_empty() { | ||
| ctx.run_type() | ||
| .execute(vscode) | ||
| .arg("--profile") | ||
| .arg(ctx.config().vscode_profile()) | ||
| .arg("--update-extensions") | ||
| .status_checked() | ||
| } else { | ||
| ctx.run_type() | ||
| .execute(vscode) | ||
| .arg("--update-extensions") | ||
| .status_checked() | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !ctx.config().vscode_profile().is_empty() { | |
| ctx.run_type() | |
| .execute(vscode) | |
| .arg("--profile") | |
| .arg(ctx.config().vscode_profile()) | |
| .arg("--update-extensions") | |
| .status_checked() | |
| } else { | |
| ctx.run_type() | |
| .execute(vscode) | |
| .arg("--update-extensions") | |
| .status_checked() | |
| } | |
| if let Some(profile) = ctx.config().vscode_profile() { | |
| ctx.run_type() | |
| .execute(vscode) | |
| .arg("--profile") | |
| .arg(profile) | |
| .arg("--update-extensions") | |
| .status_checked() | |
| } else { | |
| ctx.run_type() | |
| .execute(vscode) | |
| .arg("--update-extensions") | |
| .status_checked() | |
| } |
src/steps/generic.rs
Outdated
| @@ -9,6 +10,7 @@ use std::{fs, io::Write}; | |||
| use color_eyre::eyre::eyre; | |||
| use color_eyre::eyre::Context; | |||
| use color_eyre::eyre::Result; | |||
| use color_eyre::owo_colors::OwoColorize; | |||
There was a problem hiding this comment.
Same here
Looks like this was imported accidentally?
src/steps/generic.rs
Outdated
| @@ -1,6 +1,7 @@ | |||
| #![allow(unused_imports)] | |||
|
|
|||
| use std::ffi::OsStr; | |||
| use std::ops::Deref; | |||
There was a problem hiding this comment.
Looks like this was imported accidentally?
There was a problem hiding this comment.
Yes, must have been imported automatically by my editor.
Removed e31ea1c
config.example.toml
Outdated
Comment on lines
295
to
297
| # Specify the profile the extensions should be updated for. | ||
| # If no profile is selected, the default one will be used. | ||
| # (default: "") |
There was a problem hiding this comment.
Suggested change
| # Specify the profile the extensions should be updated for. | |
| # If no profile is selected, the default one will be used. | |
| # (default: "") | |
| # If this is set and is a non-empty string, it specify the profile the extensions | |
| # should be updated for. | |
| # | |
| # (default: this won't be set by default) |
|
@SteveLauC thanks for the suggestions! They're appreciated, especially since I'm not a Rust dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR adds a configuration extension to allow selecting a Vscode profile for which the extensions should be updated for. If no profile is stated in the config file, the default profile is used.
Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.