Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Add support for viperML/nh. See #1044.
Two decisions I've made upfront in this PR:
whoami
crate. I found this practical as I don't want to implement these functions myself for multiple platforms. They say they support at least MacOS and Linux, and those are the two Unices that NixOS andnh
are targetting anyways, so I think we're good here.run_nix_helper
in a way that never dry-runs the twonix eval
commands, which are used to figure out which configs are available in the flake. I added a comment to explain it at line 640, but in short I want to run these in both dry and wet runs so that the outcome of wet runs can be determined in a dry run.I've run
hyperfine
on the nix eval command in my not-so-small nix flake (https://github.com/dtomvan/puntbestanden) and found that it doesn't cost a lot of time:So together this is only a slowdown of ~310 ms... I hope that's okay even for dry runs.
Standards checklist
CONTRIBUTING.md
For new steps
--dry-run
option works with this step--yes
option works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.