[DimensionReductionMetrics] #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemot into DimensionReductionMetrics
There was a problem hiding this comment.
Hi @MClemot ,
thanks a lot for this PR!
it looks all good.
that'd be wonderful if you could address my one tiny remark. Thanks!
| std::unique_ptr<KDT> kdt; | ||
| std::vector<KDT *> correspondence_kdt_map; | ||
|
|
||
| GoodDiagram goods; |
There was a problem hiding this comment.
in general, I'd recommend to add an "_" suffix at the end of member variables (to distinguish them from local variables in the code). In the rest of TTK, the member variables for the base class are written in the form thisIsMyMemberVariableName_ (see core/base/triangulation/Triangulation.h for an example).
There was a problem hiding this comment.
The same remark goes for all the header files of this PR (as well as your future PRs).
…lemot into DimensionReductionMetrics
|
That looks perfect. Thanks a lot Mattéo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following :