Skip to content

Fix wrong parameter name for UnetDecoder instantiation#1064

Closed
WanjiruCate wants to merge 3 commits into
mainfrom
WanjiruCate-patch-1
Closed

Fix wrong parameter name for UnetDecoder instantiation#1064
WanjiruCate wants to merge 3 commits into
mainfrom
WanjiruCate-patch-1

Conversation

@WanjiruCate
Copy link
Copy Markdown
Contributor

@WanjiruCate WanjiruCate commented Dec 30, 2025 •
edited
Loading

Error thrown

Errors:
  - Expected a <class 'NoneType'>
  - UnetDecoder.__init__() got an unexpected keyword argument 'use_norm'
  - UnetDecoder.__init__() got an unexpected keyword argument 'add_center_block'

EDIT

Might this issue be a problem with incompatible jsonargparse version?

@WanjiruCate WanjiruCate self-assigned this Dec 30, 2025
@WanjiruCate WanjiruCate added the bug Something isn't working label Dec 30, 2025
@WanjiruCate
Add 'add_center_block' parameter to UNetDecoder
646cea8 
Added 'add_center_block' parameter to the constructor.
@romeokienzler
Copy link
Copy Markdown
Collaborator

romeokienzler commented Jan 5, 2026

@WanjiruCate

I get those errors

 147 passed
   8 failed
     - tests/test_decoders.py:32 test_unetdecoder
     - tests/test_encoder_decoder_model_factory.py:114 test_create_pixelwise_model[UNetDecoder-regression-expected0-prithvi_eo_v2_100_tl]
     - tests/test_encoder_decoder_model_factory.py:114 test_create_pixelwise_model[UNetDecoder-segmentation-expected1-prithvi_eo_v2_100_tl]
     - tests/test_encoder_decoder_model_factory.py:400 test_create_model_with_lora[UNetDecoder-regression-expected0-prithvi_eo_v1_100]
     - tests/test_encoder_decoder_model_factory.py:400 test_create_model_with_lora[UNetDecoder-regression-expected0-prithvi_eo_v2_300]
     - tests/test_encoder_decoder_model_factory.py:400 test_create_model_with_lora[UNetDecoder-regression-expected0-clay_v1_base]
     - tests/test_encoder_decoder_model_factory.py:400 test_create_model_with_lora[UNetDecoder-segmentation-expected1-prithvi_eo_v1_100]
     - tests/test_encoder_decoder_model_factory.py:400 test_create_model_with_lora[UNetDecoder-segmentation-expected1-prithvi_eo_v2_300]
   7 skipped

@WanjiruCate
Copy link
Copy Markdown
Contributor Author

WanjiruCate commented Jan 12, 2026

Correct @romeokienzler . I created an issue here for what seemed to be the problem #1065

@romeokienzler
Copy link
Copy Markdown
Collaborator

romeokienzler commented Feb 3, 2026

cool @rosielickorish will have a look at #1065

@romeokienzler romeokienzler requested review from rosielickorish and removed request for Joao-L-S-Almeida and romeokienzler May 6, 2026 12:56
@rosielickorish
Copy link
Copy Markdown
Collaborator

rosielickorish commented May 6, 2026

Resolved by #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosielickorish rosielickorish Awaiting requested review from rosielickorish

Assignees

@WanjiruCate WanjiruCate

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WanjiruCate @romeokienzler @rosielickorish