Conversation
Fixes #33072 Signed-off-by: David Goulet <dgoulet@torproject.org>
This also adds the support for the option meaning, if set, every uncompressed directory requests will be served by the dirauth with a 503 error code. Signed-off-by: David Goulet <dgoulet@torproject.org>
Signed-off-by: David Goulet <dgoulet@torproject.org>
Pull Request Test Coverage Report for Build 8673
💛 - Coveralls |
doc/tor.1.txt
Outdated
|
|
||
| HIDDEN SERVICE OPTIONS | ||
| ---------------------- | ||
| == HIDDEN SERVICE OPTIONS |
There was a problem hiding this comment.
This change doesn't seem to belong in this pull request?
changes/ticket33072
Outdated
| @@ -0,0 +1,3 @@ | |||
| o Minor bugfix (directory authority): | |||
| - Always allow compressed directory requests. Fixes bug 33072; bugfix on | |||
There was a problem hiding this comment.
Should the changes file mention the new AuthDirRejectUncompressedRequests option?
src/core/mainloop/connection.c
Outdated
| return true; | ||
| } | ||
| if (c_method != NO_METHOD) { | ||
| /* Always answer compressed request. */ |
There was a problem hiding this comment.
Are we sure we always want to allow compressed requests?
We could just fall through to the other code, which might reject some requests, if the write bucket is low.
If an authority is getting a lot of compressed requests, we should prioritise voting over answering compressed requests.
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
There are some binary files in this PR, please remove.
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
It looks like the 0.4.2 and master code got out of sync with 0.4.3.
And the function comments need to be updated in every branch.
| * If we are a directory authority, false is returned (indicating that we | ||
| * should answer the request) if one of these conditions is met: | ||
| * - Connection is from a known relay (address is looked up). | ||
| * - AuthDirRejectRequestsUnderLoad is set to 0. | ||
| * - Compression is being used for the request (looking at c_method). |
There was a problem hiding this comment.
This comment doesn't match what the code does.
| @@ -0,0 +1,4 @@ | |||
| o Minor bugfix (directory authority): | |||
| - Always allow compressed directory requests and introduce option | |||
There was a problem hiding this comment.
Oh, the changes file is out of sync as well.
We let AuthDirRejectRequestsUnderLoad and the bandwidth buckets decide about compressed requests.
3 participants
No description provided.