Repository navigation
Preserve bulk_update object and field iterators - #2320
Merged
waketzheng merged 6 commits intoOct 24, 2026
Merged
Conversation
Merging this PR will not alter performance1 warning
Comparing |
5 of 7 tasks
IlyaKhalafi
force-pushed
the
fix/bulk-update-iterables
branch
from
October 23, 2026 16:35
6a49970 to
2c079b7
Compare
waketzheng
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bulk_update consuming object and field iterators before all batches run. With this, iterator inputs update every batch, with object membership and field names captured when the query is created.
Fixes #2317
Motivation and Context
Both inputs accept iterables, but validation exhausts object iterators and batching exhausts field iterators.
How Has This Been Tested?
The new cases fail five times on the original code, with four passing controls. The full SQLite suite passes with 1983 passed, 149 skipped and two expected failures.
make checkpasses.Checklist