Repository navigation
Restore compatible MySQL bulk upserts - #2331
Open
IlyaKhalafi wants to merge 2 commits into
Open
IlyaKhalafi wants to merge 2 commits into
IlyaKhalafi wants to merge 2 commits into
Conversation
Merging this PR will not alter performance1 warning
Comparing |
IlyaKhalafi
force-pushed
the
fix/mysql-upsert-compatibility
branch
from
October 23, 2026 16:36
6f04362 to
4210f04
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bulk upserts failing on MariaDB and older MySQL versions. With this, MySQL-family inserts use
VALUES(column)assignments without inserted-row aliases.MySQL 8.0.20 and later deprecate this syntax but still accept it. With
asyncmy, server warnings can also add a round trip to fetch and log them. This compatibility tradeoff is documented.Motivation and Context
Fixes #1422.
How Has This Been Tested?
make checkpassed. All 11 focused cases passed against MariaDB 10.11.14 with bothaiomysqlandasyncmy. The unchanged baseline failed eight of those cases. The full SQLite suite passed with 1,981 tests, 153 skips and two expected failures. MySQL 5.7 and modern MySQL were not tested live.Checklist