Repository navigation
Use model names for default field projections - #2339
Merged
waketzheng merged 4 commits intoOct 23, 2026
Merged
waketzheng merged 4 commits into
waketzheng merged 4 commits into
Conversation
Merging this PR will not alter performance1 warning
Comparing |
…efault-source-field-projections
waketzheng
approved these changes
Oct 23, 2026
d3vyce
pushed a commit
to d3vyce/tortoise-orm
that referenced
this pull request
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
dict(model)and defaultvalues_list()for fields withsource_field. With this, renamed fields keep their model names and no longer cause missing tuples or attribute errors.Fixes #2337
Motivation and Context
These defaults iterate model attributes, so they need projection keys rather than database column names. Explicit field selections keep their existing behavior. The related
refresh_from_dbfix is covered by #2335.How Has This Been Tested?
The 17 new tests include eight failures on the original code and nine passing controls. The full SQLite suite passes with 1991 passed, 149 skipped and two expected failures.
make checkpasses. All 17 new cases pass on PostgreSQL 18 with both asyncpg and psycopg. MySQL and MSSQL were not run locally.Checklist