Repository navigation
Preserve field iterators when refreshing models - #2342
Merged
waketzheng merged 4 commits intoOct 24, 2026
Merged
Conversation
Merging this PR will not alter performance1 warning
Comparing |
IlyaKhalafi
force-pushed
the
fix/refresh-field-iterators
branch
from
October 23, 2026 16:35
5668935 to
57c215e
Compare
waketzheng
approved these changes
Oct 24, 2026
d3vyce
pushed a commit
to d3vyce/tortoise-orm
that referenced
this pull request
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
refresh_from_dbsilently keeping stale values when fields are passed as an iterator. With this, the same field names are used for the query and the refresh.Empty field iterators now refresh all fields, matching empty lists.
Fixes #2341.
How Has This Been Tested?
Six regression cases fail on the original code. The focused tests pass, and the full SQLite suite has 2014 passed, 149 skipped and two expected failures. All 17 new cases also pass on PostgreSQL 18 with both asyncpg and psycopg.
make checkpasses. MySQL and MSSQL were not run locally.Checklist