Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconstructKey: Remove ciphertext padding #65

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

matthiasgeihs
Copy link
Member

@matthiasgeihs matthiasgeihs commented Sep 11, 2023

Previously, the ciphertext was padded. However, ciphertexts should in general not be padded, as it leads to decryption errors. Here we remove the padding.

Resolves #64

himanshuchawla009 and others added 2 commits September 1, 2023 15:31
Previously, the ciphertext was padded. However, ciphertexts should in
general not be padded, as it leads to decryption errors. Here we remove
the padding.
@himanshuchawla009 himanshuchawla009 changed the base branch from master to alpha September 11, 2023 05:09
Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthiasgeihs matthiasgeihs merged commit f06b3f3 into alpha Oct 4, 2023
1 check passed
@matthiasgeihs matthiasgeihs deleted the fix/decryption-error branch October 4, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retrieveShare sometimes does not retrieve the correct share
3 participants