fix: generateAddressFromPubKey and tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring
|
Closes #62 |
refactor: consolidate implementations of secp256k1
ieow
commented
Oct 16, 2023
ieow
commented
Oct 17, 2023
metalurgical
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a lot of unused and redundant code.
Fixes private key generation.
Fixes generating Ethereum addresses.
Properly serializes public key using secp256k1 library instead of helpers.
Sorts json keys for signature verification on server.
Removes unnecessary complexity from tests.
Updates test values from torus;.js
Adds missing else case where enableOneKey is true and typeOfUser is v1.
Consolidates secp256k1 implementations.
etc.