effect: Add interactive dashboard interface for audio effects#15
effect: Add interactive dashboard interface for audio effects#15dmadisetti wants to merge 2 commits intotorvalds:mainfrom
Conversation
cleanup: remove waveform, didn't seem right yet
|
The interactive dashboard is a really interesting idea, and the ability to tweak effect parameters in real time while visualizing waveforms and spectra is genuinely useful. The CFFI bridge to the C effects and keeping the same precision as the hardware path is especially nice. That said, this PR introduces a fairly large, self-contained tool along with new workflow and packaging assumptions (uv, marimo, notebook-style UI). Before we can consider merging something like this, I think we need to clarify a few things: • Whether an interactive notebook/dashboard fits the core scope of this project, or if it’s better maintained as an external companion tool. Overall, the work is impressive and clearly useful, but I’d prefer to discuss direction and possibly narrow or restructure this before moving forward. Let me know what you think. |
|
These are great organizational and scope concerns. I agree that depending on a whole web-server is a bit heavy handed. Some thoughts on making this less of a monolith:
The tree would look something like
Self contained, but highly coupled to this project. edit: woops, hit send a little early |
Adds an interactive notebook that provides real-time effect
parameter control and visualization for the guitar pedal effects.
The notebook uses CFFI to call the C audio effects directly. Audio files
are processed sample-by-sample at 48kHz with the same int32/float32
precision as the hardware implementation.
Features:
Setup:
or
also hosted here, just for kicks: https://molab.marimo.io/notebooks/nb_XrY8GPWcHPJV9rPtmbdJvo/app
disclaimer, I work on marimo professionally- but mainly like tinkering with things