Skip to content

Add requirements.txt for Python dependencies#2

Open
NourCheriff wants to merge 1 commit intotorvalds:mainfrom
NourCheriff:main
Open

Add requirements.txt for Python dependencies#2
NourCheriff wants to merge 1 commit intotorvalds:mainfrom
NourCheriff:main

Conversation

@NourCheriff
Copy link
Copy Markdown

@NourCheriff NourCheriff commented Jan 9, 2026

Add a requirements.txt file to simplify installing Python dependencies using:

pip install -r requirements.txt

This avoids the need to install each dependency manually and makes setup faster and more reproducible.

Note

Although this is a personal hobby project, I couldn’t resist submitting this PR.
I’m deeply grateful for your contributions to the world and to the tech community. Git and Linux are part of my everyday work, so please consider this PR a small thank you from me.

Signed-off-by: NourCheriff nourcherif.pitos25@gmail.com

@NourCheriff NourCheriff changed the title Add requirements.txt for python dependencies Add requirements.txt for Python dependencies Jan 9, 2026
@HOLYKEYZ
Copy link
Copy Markdown

thanks!

@NourCheriff
Copy link
Copy Markdown
Author

thanks!

You're welcome @HOLYKEYZ !

@chrisbward
Copy link
Copy Markdown

For what version of python!!!!

@NourCheriff
Copy link
Copy Markdown
Author

NourCheriff commented Jan 11, 2026

For what version of python!!!!

@chrisbward for matplotlib v3.10.8 (latest stable version) the minimum required Python version is 3.10.

For additional details, please refer to the matplotlib dependency versions documentation

@adlai
Copy link
Copy Markdown

adlai commented Jan 11, 2026

[...] please consider this PR a small thank you from me.

Signed-off-by: NourCheriff

Apologies in advance for the additional burden upon Professor Torvalds's attention span;

Nour, you might have noticed that your PR has already gotten "thumbs-down" reactions on GitHub; probably because that allows silent disapproval, rather than perpetuation of notifications caused by comments like my own.

In the future, if you keep on making drive-by PRs on GitHub and similar sites, I strongly recommend that you split your commentary more carefully between the actual commit message and the PR description in the website; your email address was included in the resulting WWW-visible page, so you're opening the door to an order-of-magnitude more spam than you would by only having your contact info present in the git metadata.

Generally, the "Signed-off-by" line can be safely deleted from the automatically populated PR description, because GH will show whether commits were actually PGP signed [or similar checks for ones generated by actions in the website]; and it looks like the human-readable summary isn't included in your commit, that only has the one line "feat: ..." description.

It is gracious of you to hope that your volunteer efforts will improve someone's hobby project; may all our interactions, both online and off, be so altruistic!

@HOLYKEYZ
Copy link
Copy Markdown

[...] please consider this PR a small thank you from me.
Signed-off-by: NourCheriff

Apologies in advance for the additional burden upon Professor Torvalds's attention span;

Nour, you might have noticed that your PR has already gotten "thumbs-down" reactions on GitHub; probably because that allows silent disapproval, rather than perpetuation of notifications caused by comments like my own.

In the future, if you keep on making drive-by PRs on GitHub and similar sites, I strongly recommend that you split your commentary more carefully between the actual commit message and the PR description in the website; your email address was included in the resulting WWW-visible page, so you're opening the door to an order-of-magnitude more spam than you would by only having your contact info present in the git metadata.

Generally, the "Signed-off-by" line can be safely deleted from the automatically populated PR description, because GH will show whether commits were actually PGP signed [or similar checks for ones generated by actions in the website]; and it looks like the human-readable summary isn't included in your commit, that only has the one line "feat: ..." description.

It is gracious of you to hope that your volunteer efforts will improve someone's hobby project; may all our interactions, both online and off, be so altruistic!

calm down dude, he did what he thought he could do, and it actually makes sense tbh, he even included that he knew it was a personal hobby project and it was just a small contribution as a thank you

Copy link
Copy Markdown

@thawancomt thawancomt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its fine

Copy link
Copy Markdown

@manishin2050 manishin2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

have you checked.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.