feat(ui): display mode-specific key bindings in footer for overlay dialogs - #9
Merged
Conversation
tosaka07
marked this pull request as ready for review
February 18, 2026 02:48
Replace footer overwrite approach with title_bottom on each dialog's Block widget, ensuring key hints are always visible inside the overlay regardless of content length.
Add expand_area helper that grows a Rect by 1 cell on each side. Use it to clear a slightly larger area before rendering overlay dialogs, preventing background text from visually merging with the dialog border and title_bottom key hints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
y/Enter: worktree | Y: worktree & branch | n/Esc: cancelEsc/Enter/q: close helpPlease wait...追加した関数 (
src/ui.rs)render_confirm_footer— Confirm モード用フッターrender_help_footer— Help モード用フッターrender_deleting_footer— Deleting モード用フッターfooter_area— フッター領域の Rect 算出ヘルパーTest plan
cargo buildでコンパイル成功を確認cargo clippy -- -D warningsで警告なしcargo testで全テスト通過cargo runで TUI を起動し、各モードでフッターが正しく切り替わることを確認C-o→ Create モード: 既存フッターC-d→ Confirm モード: Confirm 用フッターD→ Prune 確認: Confirm 用フッター?→ Help モード: Help 用フッター