fix(order): use checked arithmetic in place_order to prevent integer overflow [CO-01]#289
Merged
Leothosine merged 1 commit intoJun 24, 2026
Conversation
Fixes CO-01 as specified in issue tosirano#279: - Replace unchecked * and += with checked_mul / checked_add - Add MAX_ITEM_UNIT_PRICE and MAX_ORDER_TOTAL boundary constants - Validate unit_price and running total against constants before loop proceeds - Add tests: overflow with u32::MAX, correct multi-item total, max total boundary
Leothosine
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the unchecked arithmetic in
place_order()that allowed silent integer overflow whenquantityorunit_pricewere large values.item.unit_price * item.quantity as i128withchecked_mul+checked_addMAX_ITEM_UNIT_PRICE(1T stroops) andMAX_ORDER_TOTAL(100T stroops) boundary constants validated before and during the loopu32::MAXquantity, correct multi-item totals, max-total boundary, unit price cap rejectionChanges
contracts/order/src/lib.rs— checked arithmetic and boundary guards inplace_orderCloses #279