fix: apply CEI pattern and reentrancy guard to release_payment#292
Merged
Leothosine merged 1 commit intoJun 24, 2026
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Checks-Effects-Interactions (CEI) violation in
contracts/payment/src/lib.rswhererelease_payment()performed two token transfers before updatingpayment.statustoReleased. A malicious token contract that re-enteredrelease_payment()duringtransfer()could exploit this to drain the escrow twice.Root cause
Fix
contracts/payment/src/lib.rsReleasing(u64)variant toDataKey— a per-order reentrancy guard stored in instance storagerelease_paymentto strict CEI order:"reentrant call"ifReleasing(order_id)is already setReleasing(order_id) = truepayment.status = Released,settled_at,storage.set()— all before any external callReleasing(order_id)guardtest_escrow_and_release,test_refund,test_double_escrow_panics) continue to passtest_release_status_is_released_after_successful_call— verifies CEI orderingtest_double_release_panics_protecting_against_reentrancy— a secondrelease_paymenton the same order seesstatus=Releasedand panics, mirroring exactly what a reentrant call would encounterCloses #281