Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to Yarn PnP and clean up TS comments #106

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

jungpaeng
Copy link
Member

@jungpaeng jungpaeng commented Feb 3, 2025

Description

This PR removes unnecessary TypeScript and ESLint related comments from the codebase, specifically in the @overlay-kit/framer-motion-react-16 package. These comments were originally added to suppress TypeScript and ESLint warnings, but they are no longer needed.

Related Issue: N/A

Changes

  • Removed @ts-expect-error and ESLint disable comments from modal.tsx
  • Removed @ts-expect-error and ESLint disable comments from main.tsx
  • Reordered imports in eslint.config.cjs for better organization
  • Removed unused nodeLinker configuration from .yarnrc.yml

Motivation and Context

The codebase contained several TypeScript and ESLint suppression comments that were added during development. After recent updates and improvements to our type definitions and ESLint configurations, these suppressions are no longer necessary. Removing them helps maintain cleaner, more maintainable code.

How Has This Been Tested?

  • Verified that removing the TypeScript and ESLint comments doesn't introduce any new type errors or linting issues
  • Ran the full test suite to ensure no regressions
  • Manually tested the components in the example application to verify functionality remains unchanged

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

This is a maintenance PR that focuses on code cleanup. No functional changes are included in this update.

@jungpaeng jungpaeng self-assigned this Feb 3, 2025
Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: ac3bef7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:28am

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (988fb4e) to head (ac3bef7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files          13       13           
  Lines         273      273           
  Branches       55       55           
=======================================
  Hits          230      230           
  Misses         40       40           
  Partials        3        3           
Components Coverage Δ
overlay-kit 84.24% <ø> (ø)

@jungpaeng jungpaeng force-pushed the chore/node-linker-pnp branch from 158abd5 to ac3bef7 Compare February 3, 2025 09:26
@jungpaeng jungpaeng changed the title chore: nodeLinker to pnp chore: Switch to Yarn PnP and clean up TS comments Feb 3, 2025
@jungpaeng jungpaeng marked this pull request as ready for review February 3, 2025 09:30
@jungpaeng jungpaeng merged commit 7dc3a45 into main Feb 3, 2025
10 checks passed
@jungpaeng jungpaeng deleted the chore/node-linker-pnp branch February 3, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants