Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct favicon name, extension #115

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

fe-dudu
Copy link
Contributor

@fe-dudu fe-dudu commented Feb 13, 2025

Description

The name and extension of the favicon are being changed.

Changes

I will change the names to match the favicon.ico as specified in this link.

Motivation and Context

the favicon is not displayed correctly.

How Has This Been Tested?

You can check the correct favicon by accessing localhost:3000 using the yarn dev command.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

The document has been changed beautifully 👍

@fe-dudu fe-dudu requested a review from jungpaeng as a code owner February 13, 2025 14:05
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 1232ee6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:06pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (64e9494) to head (1232ee6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          12       12           
  Lines         274      274           
  Branches       60       60           
=======================================
  Hits          240      240           
  Misses         32       32           
  Partials        2        2           
Components Coverage Δ
overlay-kit 87.59% <ø> (ø)

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jungpaeng jungpaeng merged commit 8b62de1 into toss:main Feb 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants