Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage #117

Merged
merged 1 commit into from
Feb 15, 2025
Merged

test: improve test coverage #117

merged 1 commit into from
Feb 15, 2025

Conversation

fe-dudu
Copy link
Contributor

@fe-dudu fe-dudu commented Feb 14, 2025

Description

improve test coverage 87.59% -> 96.35%

Changes

add closeAll, unmountAll, unmount, open test

Motivation and Context

improve test coverage

How Has This Been Tested?

You can check the test using the yarn test command in packages directory.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

@fe-dudu fe-dudu requested a review from jungpaeng as a code owner February 14, 2025 11:48
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 8881ffc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:52am

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (8b62de1) to head (8881ffc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   87.59%   96.71%   +9.12%     
==========================================
  Files          12       12              
  Lines         274      274              
  Branches       60       67       +7     
==========================================
+ Hits          240      265      +25     
+ Misses         32        7      -25     
  Partials        2        2              
Components Coverage Δ
overlay-kit 96.71% <ø> (+9.12%) ⬆️

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jungpaeng jungpaeng merged commit 896f548 into toss:main Feb 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants