Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove console log on dispatchOverlay #123

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

yongsk0066
Copy link
Contributor

Description

Related Issue: Fixes N/A

Changes

Removed console.log statements used for debugging purposes.

Motivation and Context

How Has This Been Tested?

Tested manually to ensure that no console logs appear in the console

Screenshots (if appropriate):

Console log discovered when using overlay-kit
스크린샷 2025-02-20 13 56 44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 3ba385e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
overlay-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 11:07am

Copy link
Member

@jungpaeng jungpaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (3362bb7) to head (3ba385e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   95.86%   95.84%   -0.02%     
==========================================
  Files          12       12              
  Lines         290      289       -1     
  Branches       73       73              
==========================================
- Hits          278      277       -1     
  Misses         10       10              
  Partials        2        2              
Components Coverage Δ
overlay-kit 95.84% <ø> (-0.02%) ⬇️

@jungpaeng jungpaeng merged commit d02a36c into toss:main Feb 24, 2025
10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants