Skip to content

loco run - Handle shutdown for rude closes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

totten
Copy link
Owner

@totten totten commented Oct 8, 2022

Steps to reproduce

Example 1:

  1. In xfce-terminal, open a tab
  2. Start loco run
  3. In another tab, use kill -9 on the main thread
  4. The daemons continue running, but there is no easy way to view/stop them.

Example 2:

  1. In xfce-terminal, open a tab
  2. Start loco run
  3. Close the tab
  4. The daemons continue running, but there is no easy way to view/stop them.

Why

The main process running in the terminal acts as monitor/watcher/controller. These scenarios kill the monitor but not kill the monitor-ees.

The implication seems to be that the kill mechanism for these examples does not go after the entire process-group.

Comments

This PR is supposed stop the services -- even if loco's original process is killed rudely.

However, it's still in draft. It only seems to fix the kill -9 scenario (1). For "close tab" scenario (2), it's not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant