loco run - Handle shutdown for rude closes #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Example 1:
loco run
kill -9
on the main threadExample 2:
loco run
Why
The main process running in the terminal acts as monitor/watcher/controller. These scenarios kill the monitor but not kill the monitor-ees.
The implication seems to be that the
kill
mechanism for these examples does not go after the entire process-group.Comments
This PR is supposed stop the services -- even if loco's original process is killed rudely.
However, it's still in draft. It only seems to fix the
kill -9
scenario (1). For "close tab" scenario (2), it's not enough.