feat(timeout): add a timeout which can also timeout on poll_ready #677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion on Discord I mentioned it was impossible to use
Timeout
withRateLimit
becauseRateLimit
is currently waiting in thepoll_ready
but the currentTimeout
implementation doesn't care at all aboutpoll_ready
call to inner service. The main goal of this PR is to add the ability to set a timeout for both call topoll_ready
andcall
to be sure we can in case of a wait inpoll_ready
be able to interrupt/timeout the current request.I'm not good to find good names so if you have better suggestions than just
GlobalTimeout
feel free :)