Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: livekitでのqallの実装の取り込み #2598

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

kaitoyama
Copy link
Contributor

ハッカソン時に https://github.com/pikachu0310/livekit-server で作成したマイクロサービスを取り込んだ

@kaitoyama kaitoyama self-assigned this Mar 5, 2025
@kaitoyama kaitoyama requested a review from Pugma March 5, 2025 17:21
@kaitoyama kaitoyama marked this pull request as ready for review March 5, 2025 17:21
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大変お待たせしました!
これだけの量、移植だけでも大変だったかと思います
本当にありがとうございます、そしてお疲れ様です

そんなところ少々恐れ入りますが、一通り見て気になったところをいくつか挙げています
少々細かいところもありますが、ご確認をお願いします 🙇

@kaitoyama kaitoyama requested review from Pugma and Takeno-hito March 9, 2025 08:09
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改めて確認をしました!
お手数ですがもう一度チェックをお願いいたします 🙇

@kaitoyama kaitoyama requested a review from Pugma March 9, 2025 14:28
Pugma
Pugma previously approved these changes Mar 9, 2025
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい修正依頼にも対応くださってありがとうございました!
こちらで良さそうだと思います!
大変お疲れ様でした

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants