-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: livekitでのqallの実装の取り込み #2598
base: master
Are you sure you want to change the base?
Conversation
…m creation and deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大変お待たせしました!
これだけの量、移植だけでも大変だったかと思います
本当にありがとうございます、そしてお疲れ様です
そんなところ少々恐れ入りますが、一通り見て気になったところをいくつか挙げています
少々細かいところもありますが、ご確認をお願いします 🙇
Co-authored-by: Pugma <[email protected]>
Co-authored-by: Pugma <[email protected]>
Co-authored-by: Pugma <[email protected]>
Co-authored-by: Pugma <[email protected]>
Co-authored-by: Pugma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改めて確認をしました!
お手数ですがもう一度チェックをお願いいたします 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かい修正依頼にも対応くださってありがとうございました!
こちらで良さそうだと思います!
大変お疲れ様でした
Co-authored-by: Pugma <[email protected]>
ハッカソン時に https://github.com/pikachu0310/livekit-server で作成したマイクロサービスを取り込んだ