Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web example #2954

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Fix/web example #2954

merged 5 commits into from
Mar 26, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Mar 24, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Changes

  • Fixed getrandom compilation flag for wasm examples
  • Fixed wgpu import in web example
  • Added permute_nchw_to_nhwc to check for input contiguity + plane op compatibility on wasm (otherwise any plane op will enable subgroups, which might not be compatible)

Testing

Tested web examples

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (8a6f37c) to head (370c61f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../burn-cubecl/src/kernel/conv/conv2d/layout_swap.rs 63.63% 4 Missing ⚠️
...urn-cubecl/src/kernel/conv/conv2d/implicit_gemm.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
- Coverage   82.11%   82.11%   -0.01%     
==========================================
  Files         867      867              
  Lines      120268   120268              
==========================================
- Hits        98763    98762       -1     
- Misses      21505    21506       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laggui laggui requested a review from nathanielsimard March 24, 2025 17:04
@nathanielsimard nathanielsimard merged commit 226ce23 into main Mar 26, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the fix/web-example branch March 26, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants