Repository navigation
(CF-58) Fix/distribution switch host - #55
Merged
Merged
Conversation
…ed distribution changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing the selected distribution kept the host from the one just left.
The selected host lives in the URL (
/console/hosts/:host) and the distribution does not. So after a switch the console stayed on the old host's path under the new distribution and showed "No such host". The same happened after Unlink moved to the next distribution./console, which lands on the new one's first host, or its "No hosts yet" state. That covers the switcher, Unlink moving to the next one, linking another distribution, a distribution a teammate unlinked, and Settings pointing a distribution at another table.Known limit: the distribution is still not in the URL, so Back does not switch distributions. Putting it there is a separate change.
Tests
Lint, typecheck and Playwright (183/183), all green. New
e2e/distribution-switch.e2e.ts(12 specs) serves each target its own hosts and rules:/console10 of the 12 fail on
dev; the other two (the shared host name and the deep link) guard behaviour that already worked.Ticket
CF-58
Checklist
shared/schemas and theirshared/examples/were updated together (n/a)$refs the updated schemas — no inline redefinition (n/a)aws_cloudfront_distribution(except underexamples/)